Failed validation: #/definitions/QuoteSummaryResult (additionalProperty: 'twitter')

[dtslvr]

Validation Error

Minimal Reproduction

const quoteSummary = await yahooFinance.quoteSummary('ADA-USD', {
  modules: ['price', 'summaryProfile']
});

Symbol(s) that it happened for

• ADA-USD

Error Message

The following result did not validate with schema: #/definitions/QuoteSummaryResult
[
  {
    instancePath: '/summaryProfile',
    schemaPath: '#/definitions/SummaryProfile/additionalProperties',
    keyword: 'additionalProperties',
    params: { additionalProperty: 'twitter' },
    message: 'must NOT have additional properties',
    data: {
      companyOfficers: [],
      twitter: 'cardano',
      name: 'Cardano',
      startDate: 2017-10-01T00:00:00.000Z,
      description: 'Cardano (ADA) is a cryptocurrency launched in 2017. Users are able to generate ADA through the process of mining. Cardano has a current supply of 33,865,878,493.804 with 34,159,578,343.084 in circulation. The last known price of Cardano is 1.23810133 USD and is down -2.94 over the last 24 hours. It is currently trading on 296 active market(s) with $1,366,111,865.81 traded over the last 24 hours. More information can be found at https://www.cardano.org.',
      maxAge: 86400
    }
  }
]

Environment

Browser or Node: Node
Library version: 2.1.8

Additional Context

The validator seems to have a problem with the twitter attribute 😄

[gadicc]

Thanks for another report, @dtslvr. We now accept this field in assetProfile and summaryProfile.

When #401 lands, we'll be a bit less sensitive to additionalProperties (especially since Yahoo keep adding new ones from time to time and it breaks validation).

[gadicc]

🎉 This issue has been resolved in version 2.1.9 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[dtslvr]

Thanks for another report, @dtslvr. We now accept this field in assetProfile and summaryProfile.

Thank you @gadicc ❤️

When #401 lands, we'll be a bit less sensitive to additionalProperties (especially since Yahoo keep adding new ones from time to time and it breaks validation).

That sounds good!