Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(quote): support { "return": "array"* | "map" | "object" } param #151

Merged
merged 5 commits into from
Jun 1, 2021
Merged

feat(quote): support { "return": "array"* | "map" | "object" } param #151

merged 5 commits into from
Jun 1, 2021

Conversation

gadicc
Copy link
Owner

@gadicc gadicc commented Apr 28, 2021 •
edited

Relates to #150.

Changes (in quote())

  • Allows a { return: "type" } query option to force return type of array, object or map

Type

Other New Feature

Comments/notes

  • Initial support and tests
  • Proper typings for correct return type based on option
  • Docs
  • Original behaviour is return: array (the default)

@gadicc gadicc mentioned this pull request Jun 1, 2021
Closed
@codecov
Copy link

codecov bot commented Jun 1, 2021 •
edited

Codecov Report

Merging #151 (43b62e3) into devel (eb65f14) will decrease coverage by 0.27%.
The diff coverage is 99.24%.

Impacted file tree graph

@@             Coverage Diff             @@
##             devel     #151      +/-   ##
===========================================
- Coverage   100.00%   99.72%   -0.28%     
===========================================
  Files           16       22       +6     
  Lines          273      363      +90     
  Branches        77      100      +23     
===========================================
+ Hits           273      362      +89     
- Misses           0        1       +1
Impacted Files Coverage Δ
src/lib/errors.ts 100.00% <ø> (ø)
src/modules/autoc.ts 100.00% <ø> (ø)
src/modules/historical.ts 100.00% <ø> (ø)
src/modules/quoteSummary.ts 100.00% <ø> (ø)
src/modules/recommendationsBySymbol.ts 100.00% <ø> (ø)
src/modules/search.ts 100.00% <ø> (ø)
src/modules/trendingSymbols.ts 100.00% <ø> (ø)
tests/console.js 88.88% <88.88%> (ø)
src/env-node.ts 100.00% <100.00%> (ø)
src/lib/moduleExec.ts 100.00% <100.00%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6f3e60...43b62e3. Read the comment docs.

@gadicc gadicc changed the title feat(quote): initial returnAs support feat(quote): support { "return": "array"* | "map" | "object" } param Jun 1, 2021
@gadicc gadicc merged commit a2d8796 into devel Jun 1, 2021
@gadicc gadicc deleted the quote-returnAs branch June 1, 2021 07:11
gadicc pushed a commit that referenced this pull request Jun 2, 2021
@semantic-release-bot
chore(release): 1.12.0 [skip ci]
93826f3 
# [1.12.0](v1.11.0...v1.12.0) (2021-06-02)

### Bug Fixes

* **quoteSummary:** allow price=null in price,quoteType (fixes [#197](#197)) ([990dd4a](990dd4a))

### Features

* **quote:** support { "return": "array"* | "map" | "object" } param ([#151](#151)) ([a2d8796](a2d8796))
@gadicc
Copy link
Owner Author

gadicc commented Jun 2, 2021

🎉 This PR is included in version 1.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gadicc gadicc added the released label Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@gadicc