Add the ability to use callbacks. #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudomakeinstall
force-pushed
the
Callback
branch
from
4b451c0
to
1a339ae
Compare
sudomakeinstall
force-pushed
the
Callback
branch
from
1a339ae
to
35caea6
Compare
|
Great stuff, thanks so much! I'm going to take a look at #130 when I get a chance, I'm a bit buried in conference prep ATM. |
|
No worries--thanks very much for merging! Best of luck with the conference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allows the user to add callbacks, which are called on each iteration of the CPD algorithm. The callbacks are stored as a vector of
std::functionspecializations, such that function pointers, pointers to methods, and lambda functions may all be passed as callbacks. A simple example is also added.This PR is a first step in addressing this issue.