Fix correspondences #137
Merged
Fix correspondences #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadomski
force-pushed
the
correspondences
branch
2 times, most recently
from
623b814
to
3665d17
Compare
There were two problems: 1. By using the original sigma2 value, all correspondences would be `0`. 2. If the transform's Gauss transformer was non direct, the correspondences wouldn't be calculated. This patch fixes both, and adds tests.
gadomski
force-pushed
the
correspondences
branch
from
3665d17
to
80d2b54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two problems:
0.This patch fixes both, and adds tests.