Accept additional HTTP headers in create calls
#114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to what we do for `get` calls:
77ae9e0
Basically, I'm after this functionality because I want to do some
testing of the auth ratelimiting of Trip Editor. The idea is that
gapi-layer passes the X-Forwarded-For header along to TE and TE can use
it to derive the actual client IP (to use in ratelimiting counts). The
TE auth endpoint gets hit when we attempt to *create* an oauth token.
I think that some system somewhere along the path is messing with that
header, though. Having the ability to inject my own X-Forwarded-For
header may help figure out what's happening.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to what we do for
getcalls: 77ae9e0Basically, I'm after this functionality because I want to do some
testing of the auth ratelimiting of Trip Editor. The idea is that
gapi-layer passes the X-Forwarded-For header along to TE and TE can use
it to derive the actual client IP (to use in ratelimiting counts). The
TE auth endpoint gets hit when we attempt to create an oauth token.
I think that some system somewhere along the path is messing with that
header, though. Having the ability to inject my own X-Forwarded-For
header may help figure out what's happening.