Migrating utility methods from django-gapi-hooked #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI there are a couple very basic unit tests in django-gapi-hooked associated with this functionality. Basically just making sure that nothing explodes when given various combinations of bytes/unicodes for the request body and API key.
Nope, django-gapi-hooked is public. I thought you were moving it because d-g-h lists Django as a requirement and you don't want to pull that in to your non-Django app 🤔 |
|
😳 Oh that one isn't private? Ok, news to me. It was kept as a dependency in our |
|
Ok; gimme a moment, will pull in those tests too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these methods being moved here?
They exist in another project which has Django as a dependency. We have a non-Django app which uses these methods and it feels like an over-kill to also include Django libraries when we don't need them.
Will these methods be removed from the other project? i.e.
django-gapi-hooked?Not any time soon. After this PR is merged, I might add a note/comment in the code, but no plans to delete it right now. This is because I don't want to break any other project accidentally.
Will the documentation be updated to reflect the existence of these methods here?
Yes. At least, I'm looking to update these pages;
https://developers.gadventures.com/docs/webhooks.html#registering-a-webhook
https://developers.gadventures.com/docs/webhooks.html#verifying-a-webhook
after this PR is merged.