Adding shouldUpdate and onUpdate functions for customized rerendering #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
requested changes
Sep 18, 2017
src/index.js
Outdated
| @@ -24,13 +24,16 @@ function traverseRenderedChildren(internalInstance, callback, argument) { | |||
| } | |||
| } | |||
|
|
|||
| function setPendingForceUpdate(internalInstance) { | |||
| function setPendingForceUpdate(internalInstance, shouldUpdate) { | |||
| if (shouldUpdate && !shouldUpdate(internalInstance)) { | |||
There was a problem hiding this comment.
Can you remove the condition and instead pass a () => true function by default?
src/index.js
Outdated
| @@ -40,32 +43,37 @@ function forceUpdateIfPending(internalInstance) { | |||
| } else if (updater && typeof updater.enqueueForceUpdate === 'function') { | |||
| updater.enqueueForceUpdate(publicInstance); | |||
| } | |||
| onUpdate && onUpdate(internalInstance); | |||
There was a problem hiding this comment.
Same here, let‘s pass an empty function by default and remove the branching.
… in large applications
gaearon
approved these changes
Sep 20, 2017
Merged
This was referenced Sep 20, 2017
Closed
|
Follow up: please see #8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is really important in large applications where rerendering everything is very costly.