Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental: handle render errors #17

Closed
wants to merge 1 commit into from
Closed

Conversation

gaearon
Copy link
Owner

@gaearon gaearon commented Jun 19, 2015

It's pretty frustrating to have a render error blow up your app.
Here's an experiment in handling them.

May be worth doing for other lifecycle hooks to prevent hot updates blowing up the app.
Feedback welcome.

Open questions:

  • How to make this work in React Native
  • How configurable it needs to be
  • Whether other lifecycle hooks need similar protection

@hzoo
Copy link

hzoo commented Jun 19, 2015

Maybe configurable colors 😝

@ghost
Copy link

ghost commented Jul 22, 2015

This has been on my todo list for a while, but finally got around to it. Pulled an all-nighter and put together a working prototype for handling errors, compatible with react-hot-api. See babel-plugin-react-error-catcher. After I get some sleep I'll probably make sure everything works with webpack (it should, in theory), as I've only had a chance to test it with jspm/systemjs so far. Saw that @KeywordBrain linked to this PR on redbox-react and figured I'd chime in. :)

@davidpfahler
Copy link

For reference: #23

@gaearon
Copy link
Owner Author

gaearon commented Sep 2, 2015

I'll soon get back to error handling.
I definitely won't do it in React Hot API though: we're deprecating it.

@gaearon gaearon closed this Sep 2, 2015
@gaearon gaearon deleted the handle-render-errors branch September 2, 2015 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants