fix: move react-dom notification to AppContainer, fixes #1227

gaearon · May 16, 2019 · 28bfdd4 · 28bfdd4
1 parent f036d36
commit 28bfdd4
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/src/AppContainer.dev.js b/src/AppContainer.dev.js
@@ -28,6 +28,14 @@ class AppContainer extends React.Component {
     generation: 0,
   };
 
+  constructor(props) {
+    super(props);
+    if (configuration.showReactDomPatchNotification) {
+      configuration.showReactDomPatchNotification = false;
+      console.warn('React-Hot-Loader: react-🔥-dom patch is not detected. React 16.6+ features may not work.');
+    }
+  }
+
   shouldComponentUpdate(prevProps, prevState) {
     // Don't update the component if the state had an error and still has one.
     // This allows to break an infinite loop of error -> render -> error -> render

diff --git a/src/configuration.js b/src/configuration.js
@@ -17,6 +17,9 @@ const configuration = {
   // Disable "hot-replacement-render" when injection into react-dom is made
   disableHotRendererWhenInjected: false,
 
+  // Controls `react-🔥-dom patch` notification
+  showReactDomPatchNotification: true,
+
   // Hook on babel component register.
   onComponentRegister: false,
 

diff --git a/src/reactHotLoader.js b/src/reactHotLoader.js
@@ -106,10 +106,8 @@ const reactHotLoader = {
       configuration.ignoreSFC = configuration.ignoreSFCWhenInjected;
 
       reactHotLoader.IS_REACT_MERGE_ENABLED = true;
+      configuration.showReactDomPatchNotification = false;
       // console.warn('react-🔥-loader activated.');
-    } else {
-      // Actually everything works...
-      console.warn('React-Hot-Loader: react-🔥-dom patch is not detected. React 16.6+ features may not work.');
     }
     /* eslint-enable */
     if (!React.createElement.isPatchedByReactHotLoader) {