Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure we’re not breaking code by inserting a function #263

Closed
gaearon opened this issue Apr 28, 2016 · 1 comment
Closed

Make sure we’re not breaking code by inserting a function #263

gaearon opened this issue Apr 28, 2016 · 1 comment
Labels
bug

Comments

@gaearon
Copy link
Owner

gaearon commented Apr 28, 2016

Relevant to: webpack/webpack#2399
We probably should put ; before and after the (function () { ... })().
This might be necessary both for Babel and Webpack parts.

A pull request is welcome.
@gaearon gaearon added the bug label Apr 28, 2016
@gaearon gaearon added this to the v3.0 milestone Apr 28, 2016
@gaearon gaearon mentioned this issue Apr 28, 2016
Closed
gaearon added a commit that referenced this issue Apr 30, 2016
@gaearon
Ensure we emit semis before and after generated code
b11621b 
Fixes #263
@gaearon
Copy link
Owner Author

gaearon commented Apr 30, 2016

Fixed in react-hot-loader@3.0.0-beta.0.

@gaearon gaearon closed this as completed Apr 30, 2016
@calesce calesce mentioned this issue Sep 15, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gaearon