-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
does not support displaying syntax errors #388
Comments
btw, the Bare minimum hot loader example is too minimum ,, I mean, it's quite rare that Anyway, not sure if you want to flesh it out a bit, maybe just make it work with
which is what I was doing in my opening question. I'm happy to make a pull request if you think is worth it. thanks |
RHL uses Redbox-React just to display errors caught in A simple example of using RHL3 with Redux is here. I agree we more simple examples using common libs in our docs. |
@calesce thanks for answering my question. So you are saying RHL can't handle syntax errors, and if we want handle that, we have to switch to I'm actually explicitly calling
above code doesn't work on RHL , but it worked on last question, can I use RHL with |
Syntax errors aren't the concern of React Hot Loader, but since it integrates with Webpack, I'm just recommending the surrounding tools for the best (in my opinion) dev experience. Right now those choices are either WDS or dev+hot middleware (both work with RHL). When I say syntax errors, I'm talking about errors that fail at parse/compile-time, which would be before they get to RHL or a Hope that's helpful. |
I previously used webpack-hot-middleware with HotModuleReplacementPlugin to do hot re-loading, and I also used redbox-react to display a nice error page in case of syntax errors. My source code is something like below
above code works fine and will gives me a nice error page whenever there is a syntax error in my updated module
I then switched to react-hot-loader , latest version (react-hot-loader@3.0.0-beta.5), something like
it works as expected, , just not showing the RedBox i was expecting in case of syntax error. I reckon it's because of 'webpack/hot/only-dev-server' that prevent hot reloading when syntax errors. why?
The text was updated successfully, but these errors were encountered: