Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stack overflow when hotifying class twice #52

Closed
gaearon opened this issue Dec 31, 2014 · 1 comment
Closed

Stack overflow when hotifying class twice #52

gaearon opened this issue Dec 31, 2014 · 1 comment

Comments

@gaearon
Copy link
Owner

gaearon commented Dec 31, 2014

Say I have A.js that looks like this:

module.exports = require('./B');

This will currently cause stack overflow in hot loader when changing B because it tries to hotify the same module twice, and uses patched version as source of truth.
gaearon added a commit that referenced this issue Dec 31, 2014
@gaearon
Update react-hot-api to include fix for #52
15f3034
@gaearon
Copy link
Owner Author

gaearon commented Dec 31, 2014

Fixed via 15f3034 (gaearon/react-hot-api@148c5ab).

Published on NPM as 1.0.5.

@gaearon gaearon closed this as completed Dec 31, 2014
gregberge pushed a commit that referenced this issue Oct 29, 2017
@Restuta @gregberge
replacing prototype.find on lodash find, since it breaks in IE11 !
4861411 
closes #52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gaearon