Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0.0-beta.11] Untranspiled RHL code in production bundle #758

Closed
apostolos opened this issue Dec 30, 2017 · 5 comments
Closed

[4.0.0-beta.11] Untranspiled RHL code in production bundle #758

apostolos opened this issue Dec 30, 2017 · 5 comments
Labels

Comments

@apostolos
Copy link

Description

Production bundle includes untraspiled *.prod.js code. Among other things, this breaks Uglify minifaction step.

Expected behavior

Stub code should be transpiled.

Actual behavior

The content of the following files is included "as is" on the main webpack chunk:

Environment

React Hot Loader version: 4.0.0-beta.11
Babel: 7.0.0-beta.36
Webpack: 4.0.0-alpha.2

Reproducible Demo

https://github.com/LWJGL/lwjgl3-www

@theKashey
Copy link
Collaborator

Thank you. Will fix asap.

@SuhairZain
Copy link

@theKashey Hey,
Is there an update on this? We were looking to migrate from v3 to v4 because of an issue with setState. But doing so would break our production build with uglify.

@theKashey
Copy link
Collaborator

PR already opened. Waiting for completion.

gregberge added a commit that referenced this issue Jan 1, 2018
gregberge added a commit that referenced this issue Jan 1, 2018
@gregberge gregberge removed the WIP label Jan 2, 2018
@gregberge
Copy link
Collaborator

Fixed in v4.0.0-beta.12

@apostolos
Copy link
Author

Many thanks!

RHL v4 now in production here: https://www.lwjgl.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants