Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RHL babel plugin will ignore react and react-hot-loader, fixes #900 #1003

Merged
merged 1 commit into from
Jun 5, 2018

Conversation

theKashey
Copy link
Collaborator

This PR just blacklist react and react-hot-loader for RHL's babel plugin, thus solving cyclic dependency.

The approach I proposed in #900, ie just exclude node_modules from babel plugin is not good idea, as long we need babel plugin inside node modules for ❄️cold components, ie we need registers to blacklist by file location.

@codecov-io
Copy link

Codecov Report

Merging #1003 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1003      +/-   ##
=========================================
+ Coverage   86.65%   86.7%   +0.04%     
=========================================
  Files          31      31              
  Lines         802     805       +3     
  Branches      189     189              
=========================================
+ Hits          695     698       +3     
  Misses         89      89              
  Partials       18      18
Impacted Files Coverage Δ
src/babel.dev.js 94.91% <100%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ec2521...e90a25c. Read the comment docs.

@theKashey theKashey merged commit 1be2966 into master Jun 5, 2018
@gregberge gregberge deleted the webpack4-babel-cycle branch July 11, 2018 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants