Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: element could be double-proxied #1033

Merged
merged 1 commit into from
Jul 22, 2018
Merged

fix: element could be double-proxied #1033

merged 1 commit into from
Jul 22, 2018

Conversation

theKashey
Copy link
Collaborator

Still walking around React+TypeScript solution, trying to find a better(a faster) way to handle it (@Akuukis, I did not forget about your PR), and this is yet another finding.

Bug: components could be double proxied, if someone, by some reason uses "pre-proxied" version or RHL.

@codecov-io
Copy link

Codecov Report

Merging #1033 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1033      +/-   ##
==========================================
+ Coverage   86.68%   86.71%   +0.03%     
==========================================
  Files          31       31              
  Lines         826      828       +2     
  Branches      191      191              
==========================================
+ Hits          716      718       +2     
  Misses         91       91              
  Partials       19       19
Impacted Files Coverage Δ
src/reactHotLoader.js 94.28% <100%> (+0.16%) ⬆️
src/reconciler/proxies.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d0f8c5...6af3883. Read the comment docs.

@theKashey theKashey merged commit d8e2457 into master Jul 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants