Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack loader #1098

Merged
merged 8 commits into from
Nov 8, 2018
Merged

Webpack loader #1098

merged 8 commits into from
Nov 8, 2018

Conversation

theKashey
Copy link
Collaborator

Reintroduce webpack loader:

  • to use it on node_modules (to cold everything)
  • to use with typescript
  • to use with react-hooks, as long they would not require eval stuff we are inject via babel right now.

@codecov-io
Copy link

codecov-io commented Nov 7, 2018

Codecov Report

Merging #1098 into master will decrease coverage by 0.23%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1098      +/-   ##
==========================================
- Coverage   87.33%   87.09%   -0.24%     
==========================================
  Files          32       32              
  Lines         884      891       +7     
  Branches      209      213       +4     
==========================================
+ Hits          772      776       +4     
- Misses         93       95       +2     
- Partials       19       20       +1
Impacted Files Coverage Δ
src/configuration.js 100% <ø> (ø) ⬆️
src/reactHotLoader.js 88.37% <66.66%> (-6.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83a4961...b0ec7d5. Read the comment docs.

@theKashey
Copy link
Collaborator Author

Gonna merge this, combine with React 16.6, add a bit if other fixes, and call it a day.

@theKashey theKashey merged commit 7f7c67d into master Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants