Replace lodash/merge with a very simple deep merge #1288
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is by no means an equivalent function, but I'm just wondering - isn't this enough?
In fact, maybe the
updateProxyById
code could be restructured to avoid the need to deep merge in the first place? I'm not familiar with the code enough to know if this merge replacement is sufficient to mergerenderOptions
andcomponentOptions
.Note, even arrays are merged differently using this code:
Fix #1269