Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added test case for createClass and createFactory #278

Merged
merged 2 commits into from
May 2, 2016
Merged

added test case for createClass and createFactory #278

merged 2 commits into from
May 2, 2016

Conversation

nfcampos
Copy link
Collaborator

@nfcampos nfcampos commented May 2, 2016 •
edited

  • test case for createClass is passing
  • test case for createFactory is failing

for #276

@nfcampos nfcampos mentioned this pull request May 2, 2016
Closed
@nfcampos
Copy link
Collaborator Author

nfcampos commented May 2, 2016

@gaearon should I merge these failing tests before we add the fix?

@gaearon
Copy link
Owner

gaearon commented May 2, 2016

Yeah, let’s do this.

@nfcampos nfcampos merged commit 750afd7 into next May 2, 2016
@nfcampos nfcampos deleted the bug-276 branch May 2, 2016 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nfcampos @gaearon