fix: construction sideEffect #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #970 +/- ##
==========================================
+ Coverage 89.02% 89.06% +0.04%
==========================================
Files 30 30
Lines 729 741 +12
Branches 166 168 +2
==========================================
+ Hits 649 660 +11
- Misses 66 67 +1
Partials 14 14
Continue to review full report at Codecov.
|
|
Sweet. Do not release until |
|
when will release 4.1.4? :) |
|
@neoziro - today? But 4.2.0? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes "construction" side effect, @neoziro found while debugging Loadable-components.
In short - RHL will construct Components to examine internal changes, even if user never used them in real.
This PR making this operation possible only for mounted components, postponing until usage for the rest.