Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing tests for auto-binded class methods defined via arrow functions. #8

Closed
wants to merge 1 commit into from

Conversation

nikolaymatrosov
Copy link

I scetched some tests that follow pattern that I use to define auto-binded method in ES6 classes. I tried to highlight the problem I have encountered using previous version of React Hot Loader. The tests could be wrong, I just wanted to add some illustration to my feature request. It would be awesome if the new version of Hot Reloader could handle this case.

@gaearon
Copy link
Owner

gaearon commented Aug 22, 2015

👍

These are currently really problematic (I don't know how to handle them).
My best bet is to create a separate Babel plugin that will help React Proxy realize what's going on there.

@gaearon
Copy link
Owner

gaearon commented Aug 22, 2015

By the way (don't mean to be pedantic) this is class property syntax proposed for ES7.
It's not part of ES6.

@nikolaymatrosov
Copy link
Author

I know. But it compiles with --stage 0, so it is good enough for me;)

On Saturday, August 22, 2015, Dan Abramov notifications@github.com wrote:

By the way (don't mean to be pedantic) this is class property syntax
proposed for ES7. It's not part of ES6.


Reply to this email directly or view it on GitHub
#8 (comment).

@jbrantly
Copy link

I ran into this as well and was going to make a PR with failing tests but you did the work for me. Thanks! Hope something can be figured out for these since they're so darn useful with React.

@gaearon
Copy link
Owner

gaearon commented Sep 24, 2015

I want to avoid spending significant effort here until we're at least sure this is the way properties will end up. So far the news aren't very encouraging:

https://twitter.com/sebmarkbage/status/646473000749928448
https://twitter.com/sebmarkbage/status/646486868888911872
https://twitter.com/sebmarkbage/status/646489649972580353

@ramivalta
Copy link

Might it be time to revisit this now that the proposal is at stage 2 and new react docs refer to this feature (albeit with an experimental feature caveat)?

@selbekk
Copy link

selbekk commented Feb 16, 2017

+1 - is this something we can start looking into?

@wkwiatek wkwiatek changed the base branch from master to 2.x March 6, 2017 09:05
@wkwiatek wkwiatek changed the base branch from 2.x to master March 6, 2017 10:14
@wkwiatek
Copy link
Collaborator

wkwiatek commented Mar 9, 2017

I guess this PR is not valid for v3-alpha, am I right @nikolaymatrosov ?

@gajus
Copy link

gajus commented Apr 28, 2017

@noinkling
Copy link

noinkling commented Jul 28, 2017

Proposal is now stage 3.

@rjhilgefort
Copy link

Any news on supporting this now that it's at stage 3?

@Fr33maan
Copy link

@gaearon Hi, I've read your thoughts on this feature from 2015/2016. Now it's in a good way of being part of one of the norm. Do you think the effort worth the benefits ?
Thanks for your job and your projects ! All contributors of redux are life saviors !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants