Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split JSONTree into its own npm package? #85

Closed
chibicode opened this issue Aug 24, 2015 · 3 comments
Closed

Split JSONTree into its own npm package? #85

chibicode opened this issue Aug 24, 2015 · 3 comments

Comments

@chibicode
Copy link
Contributor

Hi, I'm wondering if JSONTree can be its own npm package. I need a JSON viewer for my app, and I thought it'd be nice if I can use this.
https://github.com/gaearon/redux-devtools/blob/master/src/react/JSONTree/index.js

Of course I can just import redux-devtools/src/react/JSONTree but it'd be nicer if it's in own npm package. I can make a PR if that's ok.

For now, I think I'm going to use this:
https://github.com/Lapple/react-json-inspector

@gaearon
Copy link
Contributor

gaearon commented Aug 24, 2015

Please make a PR. We want to split LogMonitor itself too: #61. Splitting JSONTree is a nice start.

Please make sure to keep the credits somewhere in package.json and/or README:

// ES6 + inline style port of JSONViewer https://bitbucket.org/davevedder/react-json-viewer/
// all credits and original code to the author
// Dave Vedder <veddermatic@gmail.com> http://www.eskimospy.com/
// port by Daniele Zannotti http://www.github.com/dzannotti <dzannotti@me.com>

@chibicode
Copy link
Contributor Author

@gaearon thanks! Made a pull request: #86

@gaearon
Copy link
Contributor

gaearon commented Aug 26, 2015

Awesome, out in 1.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants