Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task Convert_Pester_Coverage fails when using preview of Pester #301

Closed
johlju opened this issue Jun 1, 2021 · 0 comments
Closed

Task Convert_Pester_Coverage fails when using preview of Pester #301

johlju opened this issue Jun 1, 2021 · 0 comments
Labels
bug The issue is a bug. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@johlju
Copy link
Collaborator

johlju commented Jun 1, 2021

If using a preview version of Pester and the task Convert_Pester_Coverage is used, then this row fails

Sampler/.build/tasks/JaCoCo.coverage.build.ps1

Line 335 in 7ca89da

$pesterVersion = [System.Version] $pesterObject.Version

It must be changed to this or something similar to this:

$pesterObjectVersion, $pesterObjectPrerelease = $pesterObject.Version -split '-'

$pesterVersion = [System.Version] $pesterObjectVersion
@johlju johlju added bug The issue is a bug. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. labels Jun 1, 2021
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Jun 25, 2021
@johlju johlju mentioned this issue Jun 25, 2021
Merged
11 tasks
johlju added a commit that referenced this issue Jun 25, 2021
@johlju
Fix Pester 5 bugs (#308)
5a70545 
- The task `Invoke_Pester_Tests_v5` no longer fails when using Pester 
  v5.3.0-alpha5 (issue #307).
- The task `Convert_Pester_Coverage` no longer fails when using a preview
  version of Pester (issue #301).
@johlju johlju closed this as completed Jun 25, 2021
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug The issue is a bug. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johlju