Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templates precompilation #5

Merged
merged 2 commits into from
Apr 1, 2012
Merged

Templates precompilation #5

merged 2 commits into from
Apr 1, 2012

Conversation

musketyr
Copy link
Contributor

task to precompile gtpl templates

@musketyr
Copy link
Contributor Author

found a few bugs. let you know when ready

@musketyr musketyr closed this Mar 21, 2012
@glaforge
Copy link

Don't forget to document the flag and so on, if you haven't done so ;-)

@musketyr musketyr reopened this Mar 22, 2012
@musketyr
Copy link
Contributor Author

lol :) github is sometimes too clever :) I'll do it as soon as the gaelyk@20 issue is closed :) I'll have to rewrite binary plugins too, so I'll do it at once.

@glaforge
Copy link

Ok!

@ghost ghost assigned bmuschko Apr 1, 2012
@bmuschko bmuschko merged commit 0b91e58 into gaelyk:master Apr 1, 2012
@bmuschko
Copy link
Member

bmuschko commented Apr 1, 2012

@musketyr I added you to the contributors for this project so you can directly push your changes. As @glaforge mentioned can you also document the new task? I didn't completely follow the discussions around the Groovy template compilation but merged your change. Can you give me some feedback if it's working as expected? I will soon add it the Gaelyk template project.

@musketyr
Copy link
Contributor Author

musketyr commented Apr 1, 2012

sure. sorry, now it's me who haven't time enought but I'll try to do it as soon as possible.

@glaforge
Copy link

glaforge commented Apr 2, 2012

Documentation is indeed really important. Thank you guys :-)
As I often say, an undocumented feature doesn't really exist!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants