Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install.sh broken #87

Closed
ohnonot opened this issue Jun 28, 2018 · 1 comment
Closed

install.sh broken #87

ohnonot opened this issue Jun 28, 2018 · 1 comment

Comments

@ohnonot
Copy link

ohnonot commented Jun 28, 2018

I've been using hostsblock on archlinux, installed via aur, no major problems.
today i tried to install it on ubuntu, "the easy way".

basically everything failed.

  1. it seems the group hostsblock already existed on my computer, and the installation failed.
    so i exited the script and created user & group hostsblock manually, then re-ran install.sh.
    however, $HOMEDIR is defined only if user hostsblock does not exist yet! the script later happily (and silently) installed config files into the root directory /.

  2. even worse, $DESTDIR is not checked for being an existing directory, only making sure it's not zero length, but that twice. why not use [ -d "$d" ] && [ -w "$d" ] here???
    i must have accidenatlly input some garbage, because the script then happily (and silently) installed executables into the root directory /.

frankly, considering that hostsblock itself is a bash script, i am appalled.

@gaenserich
Copy link
Owner

Thanks for letting me know. Give the latest git version a try.

Should be resolved by f073880

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants