Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sonarcloud coverage #10

Merged
merged 18 commits into from
Oct 17, 2022
Merged

add sonarcloud coverage #10

merged 18 commits into from
Oct 17, 2022

Conversation

patdnr
Copy link
Contributor

@patdnr patdnr commented Oct 11, 2022

No description provided.

@patdnr
Copy link
Contributor Author

patdnr commented Oct 11, 2022

Running the same command locally gives result, while Github Actions does not produce any.
image

image

@patdnr
Copy link
Contributor Author

patdnr commented Oct 11, 2022

See gaepdit/EPD-IT#82

Copy link
Member

@dougwaldron dougwaldron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you were having trouble getting coverlet to work. I'm pretty sure it was just a typo (see code comment below).

When I use the dotnet-coverage command you currently have, I get a lot of extraneous results (see screenshot), plus error messages when using report generator.
image

You could probably get it to work with some additional tweaking, but it's probably easier to go back to coverlet.

.github/workflows/sonarcloud-scan.yml Outdated Show resolved Hide resolved
@dougwaldron
Copy link
Member

It looks like your latest commit is working. I tried getting coverlet to work as well and got the same result as you: The command works fine when run locally but returns no results on GitHub. But since you got this other method to work, it's not worth pursuing.

One question though. Is the trx logger option still needed or was that just for testing? If it's not needed, please remove, and I'll merge this on Monday. Thanks for your great work on this!

@sonarcloud
Copy link

sonarcloud bot commented Oct 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@patdnr
Copy link
Contributor Author

patdnr commented Oct 14, 2022

the result-directory option used to require the logger option to work (https://stackoverflow.com/questions/49390416/dotnet-test-not-creating-test-results-folder). I have tested it locally, and it is not needed anymore.

@dougwaldron
Copy link
Member

the result-directory option used to require the logger option to work (https://stackoverflow.com/questions/49390416/dotnet-test-not-creating-test-results-folder). I have tested it locally, and it is not needed anymore.

Ok, thanks. I was wondering if it was something like that.

@dougwaldron dougwaldron merged commit 6df6f22 into main Oct 17, 2022
@dougwaldron dougwaldron deleted the sonarcloud-coverage branch October 17, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants