more edgecase checks

gaffa-tape · Dec 2, 2013 · 2b2a940 · 2b2a940
1 parent f45b978
commit 2b2a940
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 7 deletions.
diff --git a/paths.js b/paths.js
@@ -141,12 +141,14 @@ function createRootPath(){
 }
 
 function pathToParts(path){
-    if(!path && typeof path !== 'string'){
+    var pathType = typeof path;
+
+    if(pathType !== 'string' && pathType !== 'number'){
+        if(Array.isArray(path)){
+            return path;
+        }
         return;
     }
-    if(Array.isArray(path)){
-        return path;
-    }
 
     // if we haven't been passed a path, then turn the input into a path
     if (!isPath(path)) {

diff --git a/test/all.js b/test/all.js
@@ -208,7 +208,7 @@ test('bubble capturing path with bubble capture as only child key', function(t)
     );
 });
 
-test('to parts', function(t) {
+test('to parts valid path', function(t) {
     var path = '[a/b/c]'
 
     t.plan(1);
@@ -219,7 +219,7 @@ test('to parts', function(t) {
     );
 });
 
-test('to parts', function(t) {
+test('to parts valid key', function(t) {
     var path = 'a';
 
     t.plan(1);
@@ -230,7 +230,7 @@ test('to parts', function(t) {
     );
 });
 
-test('to parts', function(t) {
+test('to parts invalid key', function(t) {
     var path = 'a[b]';
 
     t.plan(1);
@@ -239,4 +239,26 @@ test('to parts', function(t) {
         paths.toParts(path),
         'no valid path'
     );
+});
+
+test('to parts boolean', function(t) {
+    var path = true;
+
+    t.plan(1);
+
+    t.notOk(
+        paths.toParts(path),
+        'true is not a path'
+    );
+});
+
+test('to parts boolean', function(t) {
+    var path = false;
+
+    t.plan(1);
+
+    t.notOk(
+        paths.toParts(path),
+        'false is not a path'
+    );
 });