Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add FetchIDL method to fetch idl json data #8

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gtsigner
Copy link

@gtsigner gtsigner changed the title Feature/fetch idl feat: add FetchIDL method to fetch idl json data Apr 27, 2022
@gagliardetto
Copy link
Owner

hey @godtoy

being able to fetch IDLs from the chain is a very useful thing to have! 😄

from a first look, it looks good to me.

but can you please use the standard go formatter?

@gtsigner
Copy link
Author

Do u mean the code formatter ? should i exec go fmt ... first right?

@gtsigner
Copy link
Author

Hey i just finished go fmt ... submit

@gagliardetto
Copy link
Owner

The tests fail because the IDL has been updated 😶‍🌫️

@gagliardetto
Copy link
Owner

How about changing the test to something like this:

  • Instead of asserting a size equality, how about asserting json content field? How about idlJSON["name"] == "nft_magiceden"?

@gtsigner
Copy link
Author

gtsigner commented May 7, 2022

Yep, u are right. Because magiceden contract has been updated 2 days ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants