Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix README code on decoding tx instruction #136

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

GCrispino
Copy link
Contributor

Fixes issues on code sample provided in section "Parse/decode an instruction from a transaction" from the README:

  • if if typo replaced with if;
  • Error check added to call to function ResolveInstructionAccounts;
  • Example transaction fetched was changed because the transaction hash that was there could not be found by the solana public testnet RPC endpoint.

Fixes issues on code sample provided in section "Parse/decode an instruction from a transaction" from the README
@gagliardetto
Copy link
Owner

Thanks!

You're right, I should have probably selected a transaction from mainnet because the other clusters do get purged from time to time.

@GCrispino
Copy link
Contributor Author

👍🏼 👍🏼

Let me know if you have any suggestion to add to the PR

@gagliardetto gagliardetto merged commit 43995cc into gagliardetto:main Nov 15, 2023
@gagliardetto
Copy link
Owner

Thanks!

@GCrispino
Copy link
Contributor Author

Thanks!

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants