Fix warnings related to strandSpecific on load and examples #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ischeller
commented
May 3, 2024
ischeller
commented
- ensures fds saved with old strandSpecific slot are loaded correctly and without warning
- sets strandSpecific of example fds to avoid it producing a warning each time
- removes warning about strandSpecific not being set for empty fds objects
- adds strand column to example external count annotation for proper merging
c-mertes
reviewed
May 8, 2024
Co-authored-by: Christian Mertes <mertes@in.tum.de>
This reverts commit 4b69ccb.
c-mertes
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.