Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README #2

Merged
merged 6 commits into from
May 26, 2020
Merged

Update README #2

merged 6 commits into from
May 26, 2020

Conversation

cyamonide
Copy link
Collaborator

This PR updates the README to include explanations on input/output, examples, and links to other helpful references.

🚧 do not merge - still testing examples for correctness
All examples are tested.

@gagoar
Copy link
Owner

gagoar commented May 25, 2020

looks really good. I wonder if you could include the defaults we are providing already in the action.yml

@cyamonide
Copy link
Collaborator Author

cyamonide commented May 25, 2020

looks really good. I wonder if you could include the defaults we are providing already in the action.yml

@gagoar sure - I'll add required and defaults.

Question about the credentials fields:
image

Is it true that if a user wanted to provide a session token instead of the access key ID/secret access key pair, they wouldn't be able to because the ID/secret pair is required?

@gagoar
Copy link
Owner

gagoar commented May 25, 2020

looks really good. I wonder if you could include the defaults we are providing already in the action.yml

@gagoar sure - I'll add required and defaults.

Question about the credentials fields:
image

Is it true that if a user wanted to provide a session token instead of the access key ID/secret access key pair, they wouldn't be able to because the ID/secret pair is required?

the configuration ask you for that right now, we can change that just changing the required: false

also this is why I've configure them that way, https://docs.aws.amazon.com/sdk-for-javascript/v2/developer-guide/loading-node-credentials-environment.html

@gagoar
Copy link
Owner

gagoar commented May 25, 2020

@cyamonide the signature for the sdk doesn't make the accessKeyId or secretAccessKey optional.
Screen Shot 2020-05-25 at 12 24 49 PM

I think the sessionToken is optional, because when it fetches something it will sign the request with the session token if present, but it will not remove the need for the other 2 attributes.

@gagoar
Copy link
Owner

gagoar commented May 25, 2020

when you are writing your examples do you mind testing it with invoke-aws-lambda@master instead of using v3?

@cyamonide cyamonide marked this pull request as ready for review May 26, 2020 03:40
@gagoar gagoar merged commit 37635ad into gagoar:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants