-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README #2
Conversation
looks really good. I wonder if you could include the defaults we are providing already in the action.yml |
@gagoar sure - I'll add required and defaults. Question about the credentials fields: Is it true that if a user wanted to provide a session token instead of the access key ID/secret access key pair, they wouldn't be able to because the ID/secret pair is required? |
edb85f3
to
0a1f6e6
Compare
0a1f6e6
to
a4e1513
Compare
the configuration ask you for that right now, we can change that just changing the also this is why I've configure them that way, https://docs.aws.amazon.com/sdk-for-javascript/v2/developer-guide/loading-node-credentials-environment.html |
@cyamonide the signature for the sdk doesn't make the I think the |
when you are writing your examples do you mind testing it with |
This PR updates the README to include explanations on input/output, examples, and links to other helpful references.
🚧 do not merge - still testing examples for correctness
All examples are tested.