Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ : add module metadata #210

Merged
merged 8 commits into from
Jan 25, 2020
Merged

✨ : add module metadata #210

merged 8 commits into from
Jan 25, 2020

Conversation

juwit
Copy link
Member

@juwit juwit commented Jan 21, 2020 •
edited
Loading

Metadata added :

  • creation date (createdAt)
  • update date (updatedAt)
  • update user (updatedBy)

♻️ : create a service for module creation

@juwit juwit requested a review from cdubuisson January 21, 2020 18:40
@juwit juwit added ✨ enhancement New feature or request ✨ feature:modules module list & module edition 👌 ready for review The pull request is ready for review 👤 user:end-user end-user and removed 👌 ready for review The pull request is ready for review labels Jan 21, 2020
@juwit juwit added the 👌 ready for review The pull request is ready for review label Jan 22, 2020
@juwit juwit force-pushed the module-metadata branch 2 times, most recently from e9fe5fd to f8798e9 Compare January 22, 2020 09:53
@gaia-app gaia-app deleted a comment from sonarcloud bot Jan 23, 2020
cdubuisson
cdubuisson reviewed Jan 25, 2020
View reviewed changes
src/test/java/io/codeka/gaia/registries/service/RegistryServiceImplTest.kt Outdated

val module = registryService.importRepository("15689", RegistryType.GITLAB, user)

Mockito.verify(gitlabRegistryApi).getRepository(user, "15689")
Copy link
Member

@cdubuisson cdubuisson Jan 25, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no static imports for Mockito or Assertions ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@juwit juwit requested a review from cdubuisson January 25, 2020 10:28
@sonarcloud
Copy link

sonarcloud bot commented Jan 25, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

96.7% 96.7% Coverage
0.0% 0.0% Duplication

@cdubuisson cdubuisson self-assigned this Jan 25, 2020
@cdubuisson cdubuisson merged commit af6b3a9 into master Jan 25, 2020
@cdubuisson cdubuisson deleted the module-metadata branch January 25, 2020 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdubuisson cdubuisson cdubuisson approved these changes

Assignees

@cdubuisson cdubuisson

Labels
✨ enhancement New feature or request ✨ feature:modules module list & module edition 👌 ready for review The pull request is ready for review 👤 user:end-user end-user
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juwit @cdubuisson