Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo #119

Merged
merged 1 commit into from
Oct 5, 2018
Merged

fix typo #119

merged 1 commit into from
Oct 5, 2018

Conversation

appleboy
Copy link
Contributor

@appleboy appleboy commented Oct 5, 2018

@Skarlso Skarlso merged commit 413494f into gaia-pipeline:master Oct 5, 2018
@appleboy appleboy deleted the patch-1 branch October 5, 2018 08:49
@Skarlso
Copy link
Member

Skarlso commented Oct 5, 2018

The vault test is a weird side effect of relying on block decrypt throwing an error when it can't decrypt the secret because the password doesn't match the block size of the original password that was used.

This basically happens because we don't know the password and don't check the decrypted content for a key string to see of the decryption was successful or not.

It can happen that the library still successfully decrypts but the content wouldn't be what was expected so a different error would happen elsewhere.

I'll make this stronger by inserting a specific string alongside the encrypted text something like <SUCCESS> that I can look up and see if the decryption was successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants