Acceptance/Integration Tests introduction #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelvocks
added
the
Needs Work
michelvocks
force-pushed
the
acceptance_tests
branch
from
0a26263
to
1093930
Compare
michelvocks
changed the title
michelvocks
removed
the
Needs Work
|
One job is failing because of the race condition which should be fixed with my other PR. Once #132 has been merged and the job doesn't crash it should be ready to get merged! 🤗 |
Skarlso
approved these changes
Dec 11, 2018
michelvocks
force-pushed
the
acceptance_tests
branch
from
ddfaf74
to
abf69f8
Compare
Codecov Report
@@ Coverage Diff @@
## master #133 +/- ##
=========================================
Coverage ? 64.02%
=========================================
Files ? 25
Lines ? 2171
Branches ? 0
=========================================
Hits ? 1390
Misses ? 626
Partials ? 155
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance/Integration tests are really important because they ensure that multiple components can still work together. In the past, we did this manually which had a negativ impact on our feature development time as well as it opened the door to introduce misterious side effects into Gaia.
This PR is the start of implementing an Acceptance/Integration test framework (we just use go tests) which also requires some refactoring.