Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added/Updated screenshots for README #138

Merged
merged 2 commits into from
Dec 14, 2018

Conversation

michelvocks
Copy link
Member

@michelvocks michelvocks commented Dec 14, 2018

I updated the screenshots and instead of using rawgit (which is deprecated) we are now using the same repository.

Currently, the README in this PR is broken and does not show any screenshots because the link points to gaia-pipeline/gaia/blob/master. Once this PR has been merged it will work as usual.

@codecov-io
Copy link

codecov-io commented Dec 14, 2018

Codecov Report

Merging #138 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
+ Coverage   63.93%   64.02%   +0.09%     
==========================================
  Files          25       25              
  Lines        2171     2171              
==========================================
+ Hits         1388     1390       +2     
+ Misses        627      626       -1     
+ Partials      156      155       -1
Impacted Files Coverage Δ
workers/scheduler/scheduler.go 70.21% <0%> (+0.6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f41ff5b...2d9baaa. Read the comment docs.

@michelvocks michelvocks self-assigned this Dec 14, 2018
@michelvocks michelvocks added the Ready To Merge PR is ready to be merged into master label Dec 14, 2018
Copy link
Member

@Skarlso Skarlso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I especially love the fact that this increased the coverage. :D

@michelvocks
Copy link
Member Author

Thanks @Skarlso 🤗
Yeah, codecov is wierd sometimes 🤔

@michelvocks michelvocks merged commit 9bcc31d into gaia-pipeline:master Dec 14, 2018
@michelvocks michelvocks deleted the screenshots_update branch December 14, 2018 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready To Merge PR is ready to be merged into master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants