Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing cancelled status for pipelines. #197

Merged
merged 1 commit into from
Jul 17, 2019
Merged

Fixing cancelled status for pipelines. #197

merged 1 commit into from
Jul 17, 2019

Conversation

Skarlso
Copy link
Member

@Skarlso Skarlso commented Jul 16, 2019 •
edited
Loading

Closes #196.

Screenshot 2019-07-16 at 23 13 27

@Skarlso Skarlso requested a review from michelvocks July 16, 2019 21:15
@codecov-io
Copy link

Codecov Report

Merging #197 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #197   +/-   ##
======================================
  Coverage    62.2%   62.2%           
======================================
  Files          48      48           
  Lines        3934    3934           
======================================
  Hits         2447    2447           
  Misses       1082    1082           
  Partials      405     405
Impacted Files Coverage Δ
workers/scheduler/scheduler.go 65.43% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d44dd08...2b22916. Read the comment docs.

michelvocks
michelvocks approved these changes Jul 17, 2019
View reviewed changes
Copy link
Member

@michelvocks michelvocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Skarlso Skarlso merged commit 2382c79 into gaia-pipeline:master Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelvocks michelvocks michelvocks approved these changes

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cancelled pipelines no longer show up as cancelled, but failed.
3 participants
@Skarlso @codecov-io @michelvocks