Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.sort causes a cascading update on the vue component #220

Merged
merged 1 commit into from Oct 7, 2019

Conversation

Skarlso
Copy link
Member

@Skarlso Skarlso commented Oct 7, 2019

@michelvocks I can't believe I finally found it. The sort I added on the tags? Apparently vue doesn't like the component being updated mid display. :/ So it does a re-eval on it, which causes another sort, which causes another re-eval... etc.

I have to have a different way of sorting the tags. I tried compute: but there was a different error. I'll make something up, but for now, I'm just removing the sort so everything works again.

BTW This is a new vue addition, the old one didn't do this. :D

Closes #212

@codecov-io
Copy link

Codecov Report

Merging #220 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #220      +/-   ##
==========================================
+ Coverage    62.1%   62.13%   +0.02%     
==========================================
  Files          49       49              
  Lines        4059     4059              
==========================================
+ Hits         2521     2522       +1     
+ Misses       1124     1123       -1     
  Partials      414      414
Impacted Files Coverage Δ
workers/pipeline/update_pipeline.go 52.54% <0%> (ø) ⬆️
workers/scheduler/scheduler.go 65.74% <0%> (+0.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da70f3b...e4bb013. Read the comment docs.

@Skarlso Skarlso merged commit ec32a78 into gaia-pipeline:master Oct 7, 2019
@michelvocks
Copy link
Member

Nice! Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Worker deregister button is broken
3 participants