Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed strings.Builder which was a go 1.10 feature. Closes #47 #49

Merged
merged 1 commit into from
Jul 21, 2018

Conversation

Skarlso
Copy link
Member

@Skarlso Skarlso commented Jul 20, 2018

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #49 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   50.43%   50.43%           
=======================================
  Files          13       13           
  Lines        1039     1039           
=======================================
  Hits          524      524           
  Misses        464      464           
  Partials       51       51

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ad299e...37181bb. Read the comment docs.

Copy link
Member

@michelvocks michelvocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤗 Thanks a lot again! @Skarlso

@michelvocks michelvocks merged commit b24239f into gaia-pipeline:master Jul 21, 2018
@Skarlso
Copy link
Member Author

Skarlso commented Jul 21, 2018

No problem. I'm the one causing the trouble after all. :-) Thanks for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants