Added renewal_sent flag to licences #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flag is set to true when either an email has been sent for a renewal reminder or a renewal pdf has been created for a licence. Renewals aren't sent for licences that have been amended / renewed already. A re-issue of a licence will set the flag to back to false allowing renewal reminders to be sent for reissued licences. Changed licences 'previous_licence' flag, which wasn't being used (except for being shown in reports, which would always be empty) to 'replaced_by', which is used as part of the condition as to whether to send renewal reminders. Moved renewal reminder cron job and email code out of applications app into main, where they are more relevant.
|
This is screaming for unit test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flag is set to true when either an email has been sent for a renewal
reminder or a renewal pdf has been created for a licence.
Renewals aren't sent for licences that have been amended / renewed
already.
A re-issue of a licence will set the flag to back to false allowing
renewal reminders to be sent for reissued licences.
Changed licences
previous_licenceflag, which wasn't being used(except for being shown in reports, which would always be empty) to
replaced_by, which is used as part of the condition as to whether tosend renewal reminders.
Moved renewal reminder cron job and email code out of applications app
into main, where they are more relevant.