bart: do not alias memory in Union #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Union was inadvertently reusing a `*node` from the other table which meant that when either table was later mutated the change would appear in both tables. Add a test and fix the condition. Updates gaissmai#16
maisem
added a commit
to tailscale/tailscale
that referenced
this pull request
Mar 26, 2024
To pick up gaissmai/bart#17. Updates #deps Signed-off-by: Maisem Ali <maisem@tailscale.com>
maisem
added a commit
to tailscale/tailscale
that referenced
this pull request
Mar 26, 2024
To pick up gaissmai/bart#17. Updates #deps Signed-off-by: Maisem Ali <maisem@tailscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Union was inadvertently reusing a
*nodefrom the other table which meant that when either table was later mutated the change would appear in both tables.Add a test and fix the condition.
Updates #16