Skip to content

Commit

Permalink
Scopes should be based on /auth/, no /auth/userinfo.
Browse files Browse the repository at this point in the history
  • Loading branch information
gaizka committed Mar 25, 2013
1 parent cb66836 commit 47656b1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions lib/omniauth/strategies/gplus.rb
Expand Up @@ -7,7 +7,7 @@ class GPlus < OAuth2
token_url: 'https://www.google.com/accounts/o8/oauth2/token'
}

option :scope, 'email'
option :scope, 'userinfo.email'

option :uid_field, :uid

Expand Down Expand Up @@ -51,7 +51,7 @@ def format_scopes(scopes)
end

def format_scope(scope)
"https://www.googleapis.com/auth/userinfo.#{scope}"
"https://www.googleapis.com/auth/#{scope}"
end

def custom_parameters(params)
Expand Down
2 changes: 1 addition & 1 deletion test/lib/omniauth/strategies/gplus_test.rb
Expand Up @@ -31,7 +31,7 @@ def test_token_url_is_valid
end

def test_default_scope_is_email
expected = 'email'
expected = 'userinfo.email'
actual = strategy.options['scope']
assert_equal(expected, actual)
end
Expand Down

0 comments on commit 47656b1

Please sign in to comment.