Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot react property 'name' of undefined #11

Closed
PCreations opened this issue Dec 13, 2016 · 2 comments
Closed

Cannot react property 'name' of undefined #11

PCreations opened this issue Dec 13, 2016 · 2 comments

Comments

@PCreations
Copy link
Contributor

PCreations commented Dec 13, 2016

When using spread operator (and maybe other attribute that not might have a name property) to pass props from parent to children, the plugin fails since JSXSpreadAttribute does not have a name attribute, thus throwing an error when attempting to read the name property of this undefined value.

@PCreations PCreations changed the title Cannot react property 'name' of undefined when using JSXSpreadAttribute Cannot react property 'name' of undefined Dec 13, 2016
PCreations pushed a commit to PCreations/babel-plugin-react-css-modules that referenced this issue Dec 13, 2016
@PCreations
Copy link
Contributor Author

Oops, duplicate of #7

gajus pushed a commit that referenced this issue Dec 18, 2016
…#13 #14 #17) (#12)

* fix: added escape hatch when testing attribute that do not have a name property (#11)

* fix: object expression generated on dynamic resolution now use quote to escape properties' name (#14)

* fix: getClassName now works as expected when multiple file use runtime resolution

* fix: getClassName now works as expected when multiple file use runtime resolution
@gajus
Copy link
Owner

gajus commented Dec 18, 2016

Fixed in #12. Thank you @PCreations

@gajus gajus closed this as completed Dec 18, 2016
gajus pushed a commit that referenced this issue Dec 19, 2016
* fix: added escape hatch when testing attribute that do not have a name property (#11)

* fix: object expression generated on dynamic resolution now use quote to escape properties' name (#14)

* fix: getClassName now works as expected when multiple file use runtime resolution

* fix: getClassName now works as expected when multiple file use runtime resolution

* fix: className attribute is now correctly generated when using runtime resolution (#18)
gajus pushed a commit that referenced this issue Jan 6, 2017
* Make syntax parser configurable
* Make syntax parser configurable
* fix:  handle multiple file import with dynamic resolution (fixes #7 #11 #13 #14 #17) (#12)
* fix: added escape hatch when testing attribute that do not have a name property (#11)
* fix: object expression generated on dynamic resolution now use quote to escape properties' name (#14)
* fix: getClassName now works as expected when multiple file use runtime resolution
* fix: getClassName now works as expected when multiple file use runtime resolution
* fix: generate className when using runtime resolution (#18) (#19)
* fix: added escape hatch when testing attribute that do not have a name property (#11)
* fix: object expression generated on dynamic resolution now use quote to escape properties' name (#14)
* fix: getClassName now works as expected when multiple file use runtime resolution
* fix: getClassName now works as expected when multiple file use runtime resolution
* fix: className attribute is now correctly generated when using runtime resolution (#18)
* feat: improve error messages (#21)
* Make syntax parser configurable
* Merged upstream
* Updated the configuration section of the readme file
* docs: improve wording
* fix: add a missing comma

BREAKING CHANGE:

If your installation is using CSS, now you need to manually install scss-loader and configure it. https://github.com/gajus/babel-plugin-react-css-modules#configurate-syntax-loaders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants