-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display missing styleName anyway? #135
Comments
Interesting. I'm curious, what is your use case for wanting this behavior? |
I am guessing to visually mark objects as missing the style name. |
I'm letting our customers add their own stylesheets. So I'd like to add
classNames to quite a few dom elements but would love not to have to use a
string for those, and `styles.property` for the rest... Especially in the
extreme case that a component name/ and the CSS file name change...
Anyway I don't use any hashing of the class name so the css sheet provided
by customers persists over time...
Is that a clear example of my use case?
…On Wed, Nov 1, 2017 at 1:43 PM, Gajus Kuizinas ***@***.***> wrote:
Interesting. I'm curious, what is your use case for wanting this behavior?
I am guessing to visually mark objects as missing the style name.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#135 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABTTO_3QjpnVami4brVpTZF4zVkbjoWaks5syK21gaJpZM4QJp9P>
.
|
If you know which styles are going to be provided by the customers, could you use |
Sounds like misuse of CSS modules. If customers are expected to provide their own stylesheets, then using If the intent is that the default styles must not be use in case user styles are provided, then you might be better off with completely different solution than CSS modules, e.g. styled-components. |
Good points all around |
This probably belongs on stackoverflow... but maybe this is a feature request
Is there a way to have
handleMissingStyleName
just provide the className anyway? Sort of likeidentity-obj-proxy
?Or is there anyway you can think of to get this functionality? Another babel plugin perhaps?
The text was updated successfully, but these errors were encountered: