feat: release no-import-namespace-destructure

.README/README.md

@@ -92,6 +92,7 @@ See [ESLint documentation](https://eslint.org/docs/user-guide/configuring/config
 {"gitdown": "include", "file": "./rules/import-specifier-newline.md"}
 {"gitdown": "include", "file": "./rules/no-barrel-import.md"}
 {"gitdown": "include", "file": "./rules/no-export-all.md"}
+{"gitdown": "include", "file": "./rules/no-import-namespace-destructure.md"}
 {"gitdown": "include", "file": "./rules/no-reassign-imports.md"}
 {"gitdown": "include", "file": "./rules/no-restricted-imports.md"}
 {"gitdown": "include", "file": "./rules/no-restricted-strings.md"}

.README/rules/no-import-namespace-destructure.md

@@ -0,0 +1,7 @@
+### `no-import-namespace-destructure`
+
+_The `--fix` option on the command line automatically fixes problems reported by this rule._
+
+Disallows the practice of importing an entire module's namespace using import * as Namespace and then destructuring specific exports from it. Instead, it encourages direct importing of only the necessary named exports from a module.
+
+<!-- assertions noImportNamespaceDestructure -->

src/index.ts

@@ -8,6 +8,7 @@ import idMatch from './rules/idMatch';
 import importSpecifierNewline from './rules/importSpecifierNewline';
 import noBarrelImport from './rules/noBarrelImport';
 import noExportAll from './rules/noExportAll';
+import noImportNamespaceDestructure from './rules/noImportNamespaceDestructure';
 import noReassignImports from './rules/noReassignImports';
 import noRestrictedImports from './rules/noRestrictedImports';
 import noRestrictedStrings from './rules/noRestrictedStrings';
@@ -37,6 +38,7 @@ export = {
     'import-specifier-newline': importSpecifierNewline,
     'no-barrel-import': noBarrelImport,
     'no-export-all': noExportAll,
+    'no-import-namespace-destructure': noImportNamespaceDestructure,
     'no-reassign-imports': noReassignImports,
     'no-restricted-imports': noRestrictedImports,
     'no-restricted-strings': noRestrictedStrings,

src/rules/noImportNamespaceDestructure.ts

@@ -0,0 +1,51 @@
+import { createRule } from '../utilities';
+
+type Options = [];
+
+type MessageIds = 'noDestructureNamespace';
+
+export default createRule<Options, MessageIds>({
+  create: (context) => {
+    return {
+      VariableDeclarator(node) {
+        if (
+          node.id.type === 'ObjectPattern' &&
+          node.init &&
+          node.init.type === 'Identifier'
+        ) {
+          const importDeclaration = context
+            .getScope()
+            // @ts-expect-error we expect .name to be set
+            .variables.find((variable) => variable.name === node.init?.name)
+            ?.defs[0]?.parent;
+          if (
+            importDeclaration &&
+            importDeclaration.type === 'ImportDeclaration' &&
+            importDeclaration.specifiers.some(
+              (specifier) => specifier.type === 'ImportNamespaceSpecifier',
+            )
+          ) {
+            context.report({
+              messageId: 'noDestructureNamespace',
+              node,
+            });
+          }
+        }
+      },
+    };
+  },
+  defaultOptions: [],
+  meta: {
+    docs: {
+      description:
+        "Disallows the practice of importing an entire module's namespace using import * as Namespace and then destructuring specific exports from it. Instead, it encourages direct importing of only the necessary named exports from a module.",
+    },
+    messages: {
+      noDestructureNamespace:
+        'Do not destructure namespace imports; import only specific members needed.',
+    },
+    schema: [],
+    type: 'layout',
+  },
+  name: 'no-import-namespace-destructure',
+});

tests/rules/noImportNamespaceDestructure.ts

@@ -0,0 +1,25 @@
+import rule from '../../src/rules/noImportNamespaceDestructure';
+import { createRuleTester } from '../RuleTester';
+
+export default createRuleTester(
+  'no-import-namespace-destructure',
+  rule,
+  { parser: '@typescript-eslint/parser' },
+  {
+    invalid: [
+      {
+        code: `import * as bar from 'bar'; const { foo } = bar;`,
+        errors: [
+          {
+            messageId: 'noDestructureNamespace',
+          },
+        ],
+      },
+    ],
+    valid: [
+      {
+        code: `import * as bar from 'bar'`,
+      },
+    ],
+  },
+);