Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-flow-fix-me-comments not reporting issues #307

Closed
pathsny opened this issue Jan 28, 2018 · 6 comments
Closed

no-flow-fix-me-comments not reporting issues #307

pathsny opened this issue Jan 28, 2018 · 6 comments
Labels

Comments

@pathsny
Copy link

pathsny commented Jan 28, 2018

I have my .eslintrc rules set to include
{ 'flowtype/no-flow-fix-me-comments': 'error'}

However, it never gives me errors or warnings about // $FlowFixMe annotations.

@gajus gajus added the bug label Jan 29, 2018
@gajus
Copy link
Owner

gajus commented Jan 29, 2018

Well, it does pass the tests.

https://github.com/gajus/eslint-plugin-flowtype/blob/master/tests/rules/assertions/noFlowFixMeComments.js

Therefore, to assist further I'd need a test case where it does not.

@pathsny
Copy link
Author

pathsny commented Jan 30, 2018

I have a project locally where it doe nothing. What works best here? A tarball of code?

@gajus
Copy link
Owner

gajus commented Jan 30, 2018

A PR that replicates the error in the test case.

@gajus
Copy link
Owner

gajus commented Jan 30, 2018

Until then I am going to close the issue.

@gajus gajus closed this as completed Jan 30, 2018
@pathsny
Copy link
Author

pathsny commented Jan 31, 2018

@gajus I'm afraid I do not know how to make it work with your test framework. But here is a minimal repro case
https://gist.github.com/pathsny/51ce729587febb85d7d49dcbe2e03a3f

As you can see when you run lint (you only get lint errors about the other lint rules I have chosen, but no-flow-fix-me-comments does not report any lint errors.

screen shot 2018-01-30 at 18 21 40

@mAAdhaTTah
Copy link

mAAdhaTTah commented Feb 4, 2018

I'm also experiencing this on wp-gistpen. Added in this commit. It's a WordPress plugin but the JS works w/o needing to get that set up. Also, codeclimate is reporting the rule is missing.

Checking this locally, I don't see the handleComment function running at all. This is probably a version incompatibility. It looks like this plugin is running against v3.0.0 and I'm running v4.0.0. When I install v3.0.0, it works again, and produces a lot more errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants