New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken tests with updated eslint and babel-eslint #336
Comments
I've tried updating those as well but steered away as I've realised it is not a quick fix. Thank you for investigating. |
Good to know others are seeing this as well. I'm getting false positives for import type Foo from './foo.js' // reported as unused
class Thing {
constructor(foo: Foo) {
this.bar = foo.bar
}
}
This problem is remedied in my case by reverting to |
So the problem is probably that babel-eslint started to use eslint's new scope manager API (here) where a custom Referencer, which visits also type annotations, is implemented. This change was introduced in babel-eslint@8.1.0. This is the reason why our are failing. This new behavior kind of collides with eslint-plugin-flowtype's |
I got |
Happy to remove these and release this as a breaking change. |
OK. I will identify differences between our implementation and babel-eslint because I expect some. I think you can merge #317 if you have no problems with it. It fixes |
Closing as stale. |
Currently, when
eslint
is updated to4.19.0
andbabel-eslint
to8.2.3
, few tests of the plugin are broken. Here is the list:interface ...
should throwno-undef
errors but don't.sort-keys
, the snippet in that issue is fixed incorrectly even with oldereslint
andeslint-babel
, so it is a separate problem.no-unused-vars
tests broken.These failing tests seem to be blocker for #318.
I will try to look at some of those, but any help is appreciated.
The text was updated successfully, but these errors were encountered: