feat: add rule to make sure that object type that is spread has exact type #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @gajus. What can I do to make this new feature to be added? |
|
Thank you |
|
🎉 This PR is included in version 3.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule will add possibility to enforce spreading only exact object types, that are explicitly exact.
When object type is not exact and is spread inside other object annotation, it can lead to resulted type to be dependent on the place, where object type was spread. For example, this case, that from first look is invalid https://flow.org/try/#0C4TwDgpgBAygFgQwE4QCYAUkHtJOASwgGcoBeKAbwCgooAbCAOwHNg4AuKRgVwFsAjCEgA0NLgl4RORYEnwtRAXwDcVKqEhQAchADumHEILEylMQmZSufQSLEA6R-GRoDuY0SWqqAYyyMZKFwif04dfWx3QhJyagBICysAciw6VCSlIA
actually doesn't cause any flow errors.
One of the way to prevent such cases, is to spread only exact object types.