feat: migrate a new rule 'use-read-only-spread' #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new rule 'use-read-only-spread' originally developed and used here: https://github.com/adeira/universe/blob/91ba39d4f59ac0376121b67e443f474a6ade4feb/src/eslint-plugin-adeira/src/rules/flow-use-readonly-spread.js It prevents users from accidentally creating an object which is no longer read-only because of Flow spread operator.
|
Hi @gajus! Here is another addition to this plugin if you have some extra time for a review. Thanks! 😎 |
|
Thank you |
|
🎉 This PR is included in version 5.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
mrtnzlml
added a commit
to adeira/universe
that referenced
this pull request
Apr 6, 2021
This change finishes a migration from our custom `adeira/flow-use-readonly-spread` rule to the official `flowtype/use-read-only-spread` rule. The behavior should stay unchanged since the underlying code is basically identical. See: gajus/eslint-plugin-flowtype#472
kodiakhq bot
pushed a commit
to adeira/universe
that referenced
this pull request
Apr 6, 2021
This change finishes a migration from our custom `adeira/flow-use-readonly-spread` rule to the official `flowtype/use-read-only-spread` rule. The behavior should stay unchanged since the underlying code is basically identical. See: gajus/eslint-plugin-flowtype#472
adeira-github-bot
pushed a commit
to adeira/eslint-config-adeira
that referenced
this pull request
Apr 6, 2021
This change finishes a migration from our custom `adeira/flow-use-readonly-spread` rule to the official `flowtype/use-read-only-spread` rule. The behavior should stay unchanged since the underlying code is basically identical. See: gajus/eslint-plugin-flowtype#472 adeira-source-id: bf37c3e6bc3e80b54d97f1c9ac3157139fe76243
adeira-github-bot
pushed a commit
to adeira/fetch
that referenced
this pull request
Apr 6, 2021
This change finishes a migration from our custom `adeira/flow-use-readonly-spread` rule to the official `flowtype/use-read-only-spread` rule. The behavior should stay unchanged since the underlying code is basically identical. See: gajus/eslint-plugin-flowtype#472 adeira-source-id: bf37c3e6bc3e80b54d97f1c9ac3157139fe76243
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new rule 'use-read-only-spread' originally developed and used in
adeira/universe.It prevents users from accidentally creating an object which is no longer read-only because of Flow spread operator.
TODO: