fix: no-dupe-keys with legal duplicated keys (fixes #133) #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
object88
changed the title
|
Bump; didn't see that merge errors were introduced. Have been fixed up now. |
|
Updated my fork to keep up with master. Can this be merged in? |
gajus
approved these changes
Jan 18, 2017
gajus
requested changes
Jan 18, 2017
src/rules/noDupeKeys.js
Outdated
| value = element.id.name; | ||
| break; | ||
| case 'ObjectTypeAnnotation': | ||
| /* eslint-disable no-use-before-define */ |
There was a problem hiding this comment.
Please change /* eslint-disable */ comments to // eslint-disable-next-line no-use-before-define.
|
Change made; thanks for the feedback. |
|
Are there any other changes that I should make? |
gajus
approved these changes
Jan 25, 2017
object88
changed the title
|
I seem to have done something wrong on my end, in my fork. Will resolve this. |
|
@object88 Ping me when it is ready to be re-reviewed. |
|
OK, we are back in working order. Feel free to check it out, @gajus , and thanks! |
object88
changed the title
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #133 by validating a complex class structure with multiple methods and different keys.