feat: add flowtype-errors

[amilajack]

@gajus can you test if this works by linking? I'm getting an error saying that Definition for rule flowtype-errors/show-errors was not found if i enable flowtype-errors/show-errors was not found in my eslintrc when using the linked version of this plugin. I haven't worked with a recommended.json before I'm not sure how to debug this.

[amilajack]

Accidentally deleted the branch for this 😂 reopening

[danharper]

I'm unsure about enabling it by default for recommended, as I'm sure many people are running flow separately anyway. Thoughts @gajus?

[amilajack]

I'm unsure about enabling it by default for recommended,

It is actually disabled in recommended config. the rule is set to 0

[gajus]

I am not convinced that adding eslint-plugin-flowtype-errors just for the sake of being able to enable it via flowtype-errors/show-errors configuration is a valid use case.

To be clear, I am not suggesting to have it enabled by default either. As @danharper said, I too think that most people run Flow separately.

@amilajack I don't see the value of making users download eslint-plugin-flowtype-errors as a dependency of eslint-plugin-flowtype just for the sake so that they could be able to enable it using flowtype-errors/show-errors rule. Therefore, I am leaning towards simply documenting the existence of eslint-plugin-flowtype-errors in the README.md.

If you are Okay with this, please update to restrict changes to the README.md file. I am suggesting adding a section "Related projects" after the "Rules" section and documenting your plugin.

[amilajack]

Sure thing. I'll close this PR and create a new one for the readme update

[gajus]

@danharper I hope thats Okay with you too.