fix engines #203
Merged
fix engines #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mkwtys
commented
Mar 7, 2017
mkwtys
commented
- https://github.com/eslint/eslint/blob/master/package.json#L119
- https://github.com/babel/babel-eslint/blob/master/package.json#L34
|
There is no guarantee for v4 support. |
|
What do you mean by no guarantee for v4 support? You are running node 4 in .travis.yml so if that passes then it should be supported? Adding in this 5de0277 commit you still target node 4 so I'm confused why you decided to add only supporting node 6 and also in a non major version. |
|
See also babel/eslint-config-babel#21, which this is causing issues for |
The plan is to get rid of it at some point in relatively near future. |
object88
pushed a commit
to object88/eslint-plugin-flowtype
that referenced
this pull request
Mar 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.